Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-123409: fix IPv6Address.reverse_pointer output #123419

Merged
merged 3 commits into from
Sep 2, 2024

Conversation

picnixz
Copy link
Contributor

@picnixz picnixz commented Aug 28, 2024

I've added tests with the test vectors from the RFC pages (the suffix in the RFC is in uppercase, namely IN-ADDR.ARPA so it's not really the exact test vector).

@miss-islington-app
Copy link

Thanks @picnixz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 2, 2024
…dresses (pythonGH-123419)

Fix functionality that was broken with better textual representation for IPv4-mapped addresses (pythongh-87799)
(cherry picked from commit 77a2fb4)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 2, 2024

GH-123606 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 2, 2024
@picnixz picnixz deleted the fix/ipv6-reverse-pointer-123409 branch September 2, 2024 15:38
Yhg1s pushed a commit that referenced this pull request Sep 2, 2024
…ddresses (GH-123419) (#123606)

gh-123409: fix `IPv6Address.reverse_pointer` for IPv4-mapped addresses (GH-123419)

Fix functionality that was broken with better textual representation for IPv4-mapped addresses (gh-87799)
(cherry picked from commit 77a2fb4)

Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants